Add global http timeout for manager

[surki]

This was already done in adapter but was missed in manager. Since manager
calls scaler.IsActive() with 0 timeout, it is erring out with "context
deadline exceeded" errors when connection latency is high (like prometheus
scaler trying to contact a prometheus server running in different region)

Signed-off-by: Suresh Kumar Ponnusamy [email protected]

Checklist

• Commits are signed with Developer Certificate of Origin (DCO)
• Tests have been added
• A PR is opened to update the documentation on https://github.com/kedacore/keda-docs
• Changelog has been updated

[tomkerkhove]

Can you update our deployment YAML (https://github.com/kedacore/keda/blob/main/config/manager/manager.yaml) and open a PR to https://github.com/kedacore/charts please?

[surki]

Can you update our deployment YAML (https://github.com/kedacore/keda/blob/main/config/manager/manager.yaml) and

I see that KEDA_HTTP_DEFAULT_TIMEOUT is not set in any manifests (even for keda-metrics-apiserver). Do you want to add for both? And what value do you want to set it to? 3s? (which is the default value if not specified)

open a PR to https://github.com/kedacore/charts please?

It seems there is another PR pending for this kedacore/charts#90
do you want to create a new one, superseding that?

[zroubalik]

Can you update our deployment YAML (https://github.com/kedacore/keda/blob/main/config/manager/manager.yaml) and

I see that KEDA_HTTP_DEFAULT_TIMEOUT is not set in any manifests (even for keda-metrics-apiserver). Do you want to add for both? And what value do you want to set it to? 3s? (which is the default value if not specified)

open a PR to https://github.com/kedacore/charts please?

my 2c: I don't think that we need to set this to the manifests. If anybody wants to tweak this value, he can add it. But that's not a standard use case, so no need to add complexity over there.

[zroubalik]

Good catch, thanks!

[tomkerkhove]

Makes sense, sorry for the confusion!