From 0d4fc28245f4f232db5c479d32c45ae800d68336 Mon Sep 17 00:00:00 2001 From: Jan Wozniak Date: Fri, 12 Apr 2024 11:47:49 +0200 Subject: [PATCH] remove duplicate scaler error metric Signed-off-by: Jan Wozniak --- pkg/metricscollector/prommetrics.go | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/pkg/metricscollector/prommetrics.go b/pkg/metricscollector/prommetrics.go index acd4d95cc2c..d9bce8b041c 100644 --- a/pkg/metricscollector/prommetrics.go +++ b/pkg/metricscollector/prommetrics.go @@ -41,15 +41,6 @@ var ( }, []string{"version", "git_commit", "goversion", "goos", "goarch"}, ) - scalerErrorsTotalDeprecated = prometheus.NewCounterVec( - prometheus.CounterOpts{ - Namespace: DefaultPromMetricsNamespace, - Subsystem: "scaler", - Name: "errors_total", - Help: "DEPRECATED - will be removed in 2.16 - use a `sum(scaler_errors_total{scaler!=\"\"})` over all scalers", - }, - []string{}, - ) scalerMetricsValue = prometheus.NewGaugeVec( prometheus.GaugeOpts{ Namespace: DefaultPromMetricsNamespace, @@ -223,7 +214,6 @@ type PromMetrics struct { } func NewPromMetrics() *PromMetrics { - metrics.Registry.MustRegister(scalerErrorsTotalDeprecated) metrics.Registry.MustRegister(scalerMetricsValue) metrics.Registry.MustRegister(scalerMetricsLatencyDeprecated) metrics.Registry.MustRegister(scalerMetricsLatency) @@ -300,7 +290,6 @@ func (p *PromMetrics) RecordScalerError(namespace string, scaledResource string, scalerErrors.With(getLabels(namespace, scaledResource, scaler, triggerIndex, metric, isScaledObject)).Inc() scalerErrorsDeprecated.With(getLabels(namespace, scaledResource, scaler, triggerIndex, metric, isScaledObject)).Inc() p.RecordScaledObjectError(namespace, scaledResource, err) - scalerErrorsTotalDeprecated.With(prometheus.Labels{}).Inc() return } // initialize metric with 0 if not already set