From 0951b7a5d6304ee8d987c8e5536baedfbc0adf5a Mon Sep 17 00:00:00 2001 From: Vighnesh Shenoy Date: Thu, 15 Sep 2022 23:49:07 +0530 Subject: [PATCH 1/2] feat: Add support for SAS tokens for authentication in Azure Service Bus scaler. Signed-off-by: Vighnesh Shenoy --- content/docs/2.9/scalers/azure-service-bus.md | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/content/docs/2.9/scalers/azure-service-bus.md b/content/docs/2.9/scalers/azure-service-bus.md index b495d81b2..bc877646b 100644 --- a/content/docs/2.9/scalers/azure-service-bus.md +++ b/content/docs/2.9/scalers/azure-service-bus.md @@ -53,7 +53,16 @@ You can authenticate by using pod identity or connection string authentication. **Connection String Authentication:** -- `connection` - Connection string for Azure Service Bus Namespace. +- `connection` - Connection string for the Azure Service Bus Namespace. + + The following formats are supported. + + - With **SharedAccessKey** - + `Endpoint=sb://.servicebus.windows.net/;SharedAccessKeyName=;SharedAccessKey=` + - With **SharedAccessSignature** - + `Endpoint=sb://.servicebus.windows.net/;SharedAccessSignature=SharedAccessSignature sig=&se=&skn=&sr=` + Refer to this [page](https://docs.microsoft.com/en-us/azure/service-bus-messaging/service-bus-sas) for more information + on using Shared Access Signatures. **Pod identity based authentication:** From 44bfce9438d6ea88e331186a23a899c36b9fa269 Mon Sep 17 00:00:00 2001 From: Vighnesh Shenoy Date: Tue, 20 Sep 2022 10:52:26 +0530 Subject: [PATCH 2/2] Update older docs for clarity. Signed-off-by: Vighnesh Shenoy --- content/docs/1.4/scalers/azure-service-bus.md | 7 ++++++- content/docs/1.5/scalers/azure-service-bus.md | 7 ++++++- content/docs/2.0/scalers/azure-service-bus.md | 7 ++++++- content/docs/2.1/scalers/azure-service-bus.md | 7 ++++++- content/docs/2.2/scalers/azure-service-bus.md | 7 ++++++- content/docs/2.3/scalers/azure-service-bus.md | 7 ++++++- content/docs/2.4/scalers/azure-service-bus.md | 7 ++++++- content/docs/2.5/scalers/azure-service-bus.md | 7 ++++++- content/docs/2.6/scalers/azure-service-bus.md | 7 ++++++- content/docs/2.7/scalers/azure-service-bus.md | 7 ++++++- content/docs/2.8/scalers/azure-service-bus.md | 7 ++++++- 11 files changed, 66 insertions(+), 11 deletions(-) diff --git a/content/docs/1.4/scalers/azure-service-bus.md b/content/docs/1.4/scalers/azure-service-bus.md index 55a7f0dd7..a0f8cedc8 100644 --- a/content/docs/1.4/scalers/azure-service-bus.md +++ b/content/docs/1.4/scalers/azure-service-bus.md @@ -44,7 +44,12 @@ You can authenticate by using pod identity or connection string authentication. **Connection String Authentication:** -- `connection` - Connection string for Azure Service Bus Namespace. +- `connection` - Connection string for the Azure Service Bus Namespace. + + The following formats are supported. + + - With **SharedAccessKey** - + `Endpoint=sb://.servicebus.windows.net/;SharedAccessKeyName=;SharedAccessKey=` ### Example diff --git a/content/docs/1.5/scalers/azure-service-bus.md b/content/docs/1.5/scalers/azure-service-bus.md index 55a7f0dd7..a0f8cedc8 100644 --- a/content/docs/1.5/scalers/azure-service-bus.md +++ b/content/docs/1.5/scalers/azure-service-bus.md @@ -44,7 +44,12 @@ You can authenticate by using pod identity or connection string authentication. **Connection String Authentication:** -- `connection` - Connection string for Azure Service Bus Namespace. +- `connection` - Connection string for the Azure Service Bus Namespace. + + The following formats are supported. + + - With **SharedAccessKey** - + `Endpoint=sb://.servicebus.windows.net/;SharedAccessKeyName=;SharedAccessKey=` ### Example diff --git a/content/docs/2.0/scalers/azure-service-bus.md b/content/docs/2.0/scalers/azure-service-bus.md index 00afbf4ac..266d53fb4 100644 --- a/content/docs/2.0/scalers/azure-service-bus.md +++ b/content/docs/2.0/scalers/azure-service-bus.md @@ -46,7 +46,12 @@ You can authenticate by using pod identity or connection string authentication. **Connection String Authentication:** -- `connection` - Connection string for Azure Service Bus Namespace. +- `connection` - Connection string for the Azure Service Bus Namespace. + + The following formats are supported. + + - With **SharedAccessKey** - + `Endpoint=sb://.servicebus.windows.net/;SharedAccessKeyName=;SharedAccessKey=` ### Example diff --git a/content/docs/2.1/scalers/azure-service-bus.md b/content/docs/2.1/scalers/azure-service-bus.md index 00afbf4ac..266d53fb4 100644 --- a/content/docs/2.1/scalers/azure-service-bus.md +++ b/content/docs/2.1/scalers/azure-service-bus.md @@ -46,7 +46,12 @@ You can authenticate by using pod identity or connection string authentication. **Connection String Authentication:** -- `connection` - Connection string for Azure Service Bus Namespace. +- `connection` - Connection string for the Azure Service Bus Namespace. + + The following formats are supported. + + - With **SharedAccessKey** - + `Endpoint=sb://.servicebus.windows.net/;SharedAccessKeyName=;SharedAccessKey=` ### Example diff --git a/content/docs/2.2/scalers/azure-service-bus.md b/content/docs/2.2/scalers/azure-service-bus.md index 00afbf4ac..266d53fb4 100644 --- a/content/docs/2.2/scalers/azure-service-bus.md +++ b/content/docs/2.2/scalers/azure-service-bus.md @@ -46,7 +46,12 @@ You can authenticate by using pod identity or connection string authentication. **Connection String Authentication:** -- `connection` - Connection string for Azure Service Bus Namespace. +- `connection` - Connection string for the Azure Service Bus Namespace. + + The following formats are supported. + + - With **SharedAccessKey** - + `Endpoint=sb://.servicebus.windows.net/;SharedAccessKeyName=;SharedAccessKey=` ### Example diff --git a/content/docs/2.3/scalers/azure-service-bus.md b/content/docs/2.3/scalers/azure-service-bus.md index 00afbf4ac..266d53fb4 100644 --- a/content/docs/2.3/scalers/azure-service-bus.md +++ b/content/docs/2.3/scalers/azure-service-bus.md @@ -46,7 +46,12 @@ You can authenticate by using pod identity or connection string authentication. **Connection String Authentication:** -- `connection` - Connection string for Azure Service Bus Namespace. +- `connection` - Connection string for the Azure Service Bus Namespace. + + The following formats are supported. + + - With **SharedAccessKey** - + `Endpoint=sb://.servicebus.windows.net/;SharedAccessKeyName=;SharedAccessKey=` ### Example diff --git a/content/docs/2.4/scalers/azure-service-bus.md b/content/docs/2.4/scalers/azure-service-bus.md index 063560e48..2b59eb557 100644 --- a/content/docs/2.4/scalers/azure-service-bus.md +++ b/content/docs/2.4/scalers/azure-service-bus.md @@ -51,7 +51,12 @@ You can authenticate by using pod identity or connection string authentication. **Connection String Authentication:** -- `connection` - Connection string for Azure Service Bus Namespace. +- `connection` - Connection string for the Azure Service Bus Namespace. + + The following formats are supported. + + - With **SharedAccessKey** - + `Endpoint=sb://.servicebus.windows.net/;SharedAccessKeyName=;SharedAccessKey=` ### Example diff --git a/content/docs/2.5/scalers/azure-service-bus.md b/content/docs/2.5/scalers/azure-service-bus.md index 063560e48..2b59eb557 100644 --- a/content/docs/2.5/scalers/azure-service-bus.md +++ b/content/docs/2.5/scalers/azure-service-bus.md @@ -51,7 +51,12 @@ You can authenticate by using pod identity or connection string authentication. **Connection String Authentication:** -- `connection` - Connection string for Azure Service Bus Namespace. +- `connection` - Connection string for the Azure Service Bus Namespace. + + The following formats are supported. + + - With **SharedAccessKey** - + `Endpoint=sb://.servicebus.windows.net/;SharedAccessKeyName=;SharedAccessKey=` ### Example diff --git a/content/docs/2.6/scalers/azure-service-bus.md b/content/docs/2.6/scalers/azure-service-bus.md index 063560e48..2b59eb557 100644 --- a/content/docs/2.6/scalers/azure-service-bus.md +++ b/content/docs/2.6/scalers/azure-service-bus.md @@ -51,7 +51,12 @@ You can authenticate by using pod identity or connection string authentication. **Connection String Authentication:** -- `connection` - Connection string for Azure Service Bus Namespace. +- `connection` - Connection string for the Azure Service Bus Namespace. + + The following formats are supported. + + - With **SharedAccessKey** - + `Endpoint=sb://.servicebus.windows.net/;SharedAccessKeyName=;SharedAccessKey=` ### Example diff --git a/content/docs/2.7/scalers/azure-service-bus.md b/content/docs/2.7/scalers/azure-service-bus.md index 063560e48..2b59eb557 100644 --- a/content/docs/2.7/scalers/azure-service-bus.md +++ b/content/docs/2.7/scalers/azure-service-bus.md @@ -51,7 +51,12 @@ You can authenticate by using pod identity or connection string authentication. **Connection String Authentication:** -- `connection` - Connection string for Azure Service Bus Namespace. +- `connection` - Connection string for the Azure Service Bus Namespace. + + The following formats are supported. + + - With **SharedAccessKey** - + `Endpoint=sb://.servicebus.windows.net/;SharedAccessKeyName=;SharedAccessKey=` ### Example diff --git a/content/docs/2.8/scalers/azure-service-bus.md b/content/docs/2.8/scalers/azure-service-bus.md index b495d81b2..2f3babdde 100644 --- a/content/docs/2.8/scalers/azure-service-bus.md +++ b/content/docs/2.8/scalers/azure-service-bus.md @@ -53,7 +53,12 @@ You can authenticate by using pod identity or connection string authentication. **Connection String Authentication:** -- `connection` - Connection string for Azure Service Bus Namespace. +- `connection` - Connection string for the Azure Service Bus Namespace. + + The following formats are supported. + + - With **SharedAccessKey** - + `Endpoint=sb://.servicebus.windows.net/;SharedAccessKeyName=;SharedAccessKey=` **Pod identity based authentication:**