From 8b6c920ac4c9453176046cd3a323406a6ab57555 Mon Sep 17 00:00:00 2001 From: Zhenghan Zhou Date: Mon, 10 Jul 2023 16:22:13 +0800 Subject: [PATCH 1/4] Update Doc Signed-off-by: Zhenghan Zhou --- content/docs/2.12/concepts/admission-webhooks.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/content/docs/2.12/concepts/admission-webhooks.md b/content/docs/2.12/concepts/admission-webhooks.md index 59e9c6bf6..0a60acb30 100644 --- a/content/docs/2.12/concepts/admission-webhooks.md +++ b/content/docs/2.12/concepts/admission-webhooks.md @@ -15,3 +15,7 @@ KEDA will block all incoming changes to `ScaledObject` that don't match these ru - The scaled workload (`scaledobject.spec.scaleTargetRef`) is already autoscaled by another other sources (other ScaledObject or HPA). - CPU and/or Memory trigger are used and the scaled workload doesn't have the requests defined. **This rule doesn't apply to all the workload types, only to `Deployment` and `StatefulSet`.** - CPU and/or Memory trigger are **the only used triggers** and the ScaledObject defines `minReplicaCount:0`. **This rule doesn't apply to all the workload types, only to `Deployment` and `StatefulSet`.** + +KEDA will block all incoming changes to `TriggerAuthentication`/`ClusterTriggerAuthentication` that don't match these rules: + +- The Pod Identity has specified empty IdentityId. From 50e3e4d50b7ce031be93e0838feb74bcf4d47029 Mon Sep 17 00:00:00 2001 From: Tom Kerkhove Date: Mon, 10 Jul 2023 11:38:22 +0200 Subject: [PATCH 2/4] Update content/docs/2.12/concepts/admission-webhooks.md Signed-off-by: Tom Kerkhove --- content/docs/2.12/concepts/admission-webhooks.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/docs/2.12/concepts/admission-webhooks.md b/content/docs/2.12/concepts/admission-webhooks.md index 0a60acb30..7a8f54a73 100644 --- a/content/docs/2.12/concepts/admission-webhooks.md +++ b/content/docs/2.12/concepts/admission-webhooks.md @@ -18,4 +18,4 @@ KEDA will block all incoming changes to `ScaledObject` that don't match these ru KEDA will block all incoming changes to `TriggerAuthentication`/`ClusterTriggerAuthentication` that don't match these rules: -- The Pod Identity has specified empty IdentityId. +- The specified identity ID for Azure AD Workload Identity and/or Pod Identity is empty. From cbe4879570a39a83de6153d0cb566231e04c375a Mon Sep 17 00:00:00 2001 From: Zhenghan Zhou Date: Tue, 11 Jul 2023 09:49:25 +0800 Subject: [PATCH 3/4] Update admission-webhooks.md Signed-off-by: Zhenghan Zhou --- content/docs/2.12/concepts/admission-webhooks.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/docs/2.12/concepts/admission-webhooks.md b/content/docs/2.12/concepts/admission-webhooks.md index 7a8f54a73..7238ff9dc 100644 --- a/content/docs/2.12/concepts/admission-webhooks.md +++ b/content/docs/2.12/concepts/admission-webhooks.md @@ -18,4 +18,4 @@ KEDA will block all incoming changes to `ScaledObject` that don't match these ru KEDA will block all incoming changes to `TriggerAuthentication`/`ClusterTriggerAuthentication` that don't match these rules: -- The specified identity ID for Azure AD Workload Identity and/or Pod Identity is empty. +- The specified identity ID for Azure AD Workload Identity and/or Pod Identity is empty. (Default/unset identity ID will be passed through.) From d53ce3efe429b026bb6e3c50f91e3acca9351988 Mon Sep 17 00:00:00 2001 From: Tom Kerkhove Date: Tue, 29 Aug 2023 14:19:17 +0200 Subject: [PATCH 4/4] Update content/docs/2.12/concepts/admission-webhooks.md Co-authored-by: Jorge Turrado Ferrero Signed-off-by: Tom Kerkhove --- content/docs/2.12/concepts/admission-webhooks.md | 1 + 1 file changed, 1 insertion(+) diff --git a/content/docs/2.12/concepts/admission-webhooks.md b/content/docs/2.12/concepts/admission-webhooks.md index 7238ff9dc..3fe133508 100644 --- a/content/docs/2.12/concepts/admission-webhooks.md +++ b/content/docs/2.12/concepts/admission-webhooks.md @@ -19,3 +19,4 @@ KEDA will block all incoming changes to `ScaledObject` that don't match these ru KEDA will block all incoming changes to `TriggerAuthentication`/`ClusterTriggerAuthentication` that don't match these rules: - The specified identity ID for Azure AD Workload Identity and/or Pod Identity is empty. (Default/unset identity ID will be passed through.) + > NOTE: This only applies if the `TriggerAuthentication/ClusterTriggerAuthentication` is overriding the default identityId provided to KEDA during the installation