Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make verify is broken #694

Closed
t0rr3sp3dr0 opened this issue May 31, 2023 · 0 comments · Fixed by #695
Closed

make verify is broken #694

t0rr3sp3dr0 opened this issue May 31, 2023 · 0 comments · Fixed by #695
Labels
bug Something isn't working

Comments

@t0rr3sp3dr0
Copy link
Contributor

Report

make verify is not detecting differences in generated code as it should. Currently, the code on the master branch is out of sync and make verify succeeds anyway.

Expected Behavior

make verify should fail because the generated code is outdated.

Actual Behavior

make verify succeeds.

Steps to Reproduce the Problem

  1. Run make verify on commit a47e91f.

Logs from KEDA HTTP operator

No response

What version of the KEDA HTTP Add-on are you running?

No response

Kubernetes Version

None

Platform

None

Anything else?

No response
@t0rr3sp3dr0 t0rr3sp3dr0 added the bug Something isn't working label May 31, 2023
@t0rr3sp3dr0 t0rr3sp3dr0 mentioned this issue May 31, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Roadmap - KEDA HTTP Add-On
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix verify-codegen t0rr3sp3dr0/http-add-on
1 participant
@t0rr3sp3dr0