Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide resource requests/limits for KEDA deployment #112

Closed
tomkerkhove opened this issue Dec 24, 2020 · 7 comments · Fixed by #183
Closed

Provide resource requests/limits for KEDA deployment #112

tomkerkhove opened this issue Dec 24, 2020 · 7 comments · Fixed by #183
Assignees
@tomkerkhove
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone
KEDA Core v2.5.0

Comments

@tomkerkhove
Copy link
Member

Provide resource requests/limits for KEDA deployment
@tomkerkhove tomkerkhove added the enhancement New feature or request label Dec 24, 2020
@zroubalik
Copy link
Member

These values are in yaml, so probably just add them to the template is enough: https://github.com/kedacore/keda/blob/2a2987ab0f6020cffa9e75e18005469ca3aaf426/config/manager/manager.yaml#L37-L42

@tomkerkhove
Copy link
Member Author

They are not used as part of our Helm chart for now: https://github.com/kedacore/charts/blob/master/keda/values.yaml#L93

Will move them over as defaults as well.

Note to self, metrics service limits are here: https://github.com/kedacore/keda/blob/2a2987ab0f6020cffa9e75e18005469ca3aaf426/config/metrics-server/deployment.yaml

@tomkerkhove tomkerkhove self-assigned this Jan 4, 2021
@tomkerkhove tomkerkhove added the help wanted Extra attention is needed label Jun 22, 2021
@tomkerkhove
Copy link
Member Author

This should follow our documented limits/requests: https://keda.sh/docs/latest/operate/cluster/

@JorTurFer
Copy link
Member

JorTurFer commented Aug 30, 2021 •
edited
Loading

Should we have different resources for keda and metricsApiServer?
I guess that the operator could need different resources than the metrics server, or not 😉

@tomkerkhove
Copy link
Member Author

They are currently the same but best to separate in case we need to change them later on indeed.

@JorTurFer
Copy link
Member

OMW

@zroubalik
Copy link
Member

+1 for separation

@JorTurFer JorTurFer mentioned this issue Aug 31, 2021
Merged
3 tasks
@tomkerkhove tomkerkhove added this to the KEDA Core vNext milestone Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomkerkhove tomkerkhove

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
KEDA Core v2.5.0
Development

Successfully merging a pull request may close this issue.

Add resource requests/limits for KEDA deployment
3 participants
@zroubalik @tomkerkhove @JorTurFer