Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deque interface should be used instead of Stack class in sorting a stack #193

Open
TanyaAgarwal28 opened this issue Mar 11, 2021 · 0 comments

Comments

@TanyaAgarwal28
Copy link

TanyaAgarwal28 commented Mar 11, 2021

Hi
Stack class is used in sorting a stack u should use Deque interface instead of it because Stack has no interface, so if you know you need Stack operations you end up committing to a specific concrete class, which isn't usually a good idea.So I had make a pull request to change it #192

@TanyaAgarwal28 TanyaAgarwal28 changed the title Stack class is used in sorting a stack u should use Deque interface instead of it Stack class is used in sorting a stack u should use Deque interface instead of it because Stack has no interface, so if you know you need Stack operations you end up committing to a specific concrete class, which isn't usually a good idea.So I had make a pull request to change it Mar 11, 2021
@TanyaAgarwal28 TanyaAgarwal28 changed the title Stack class is used in sorting a stack u should use Deque interface instead of it because Stack has no interface, so if you know you need Stack operations you end up committing to a specific concrete class, which isn't usually a good idea.So I had make a pull request to change it Deque interface should be used instead of Stack class in sorting a stack Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant