Enhancement: The feature renaming dependency is incomplete

[zong-zhe]

Problem

The current kpm renaming dependency is incomplete, the current state of this function is only to replace the dependent name in kcl.mod.

This will result in the following situation:

kcl mod add helloworld:0.1.0 --rename new_helloworld

The command above will add dependency into kcl.mod as below

[dependencies]
new_helloworld = 0.1.0

And the kcl.mod.lock

[dependencies]
  [dependencies.new_helloworld]
    name = "new_helloworld"
    full_name = "new_helloworld_0.1.0"
    version = "0.1.0"

And these incomplete information does not support updating the dependency for helloworld when kcl mod update or kcl run. The link between helloworld and new_helloworld is missing.

Solution

Referring to cargo, add a package field to declare the association between new name and old name in kcl.mod.

Here is a example:

[dependencies]
new-flask-demo-kcl-manifests = { git = "https://github.com/kcl-lang/flask-demo-kcl-manifests", version = "v0.1.0", package = "flask-demo-kcl-manifests" }
flask-demo-kcl-manifests = { git = "https://github.com/kcl-lang/flask-demo-kcl-manifests", version = "v0.1.0" }

new_helloworld = { version = "1.0.0", package = "helloworld" }
helloworld = "1.0.0"

[Manoramsharma]

Hi @zong-zhe I would like to collaborate on this one.

[zong-zhe]

Hi @Manoramsharma 😃

Are you going to finish this part of the work?

[Manoramsharma]

@zong-zhe It will be better if you can add some sub-tasks that will ultimately be achieving this and I can contribute to those small sub-tasks if you think this issue to be a complex one.

[zong-zhe]

Hi @Manoramsharma 😃

The first step is to add this package field so that you can write something like this in kcl.mod

new_helloworld = {version = "1.0.204", package = "new_helloworld"} 

flask-demo-kcl-manifests_new = {git = "https://github.com/kcl-lang/flask-demo-kcl-manifests", version = "v0.1.0 ", package = “flask-demo-kcl-manifests” } 

helloworld_oci = {oci = "https://ghcr.io/kcl-lang/helloworld ", version = "v0.1.0, "package =" helloworld_oci "} 

The first PR is that kcl.mod supports reading and writing to the above formats with package.

Change the contents of this file and write the corresponding tests for your work: https://github.com/kcl-lang/kpm/blob/main/pkg/downloader/toml.go

[Gmin2]

Hey @zong-zhe

the rename flag is not working as described above
Screencast from 30-07-24 10:29:27 PM IST.webm

[zong-zhe]

Hey @zong-zhe the rename flag is not working as described above Screencast from 30-07-24 10:29:27 PM IST.webm

Hi @Gmin2 😃

kpm is currently used by the kcl cli as a library. The kpm command has not been maintained for a long time. You can try to test this function through the kcl cli.

kcl cli - https://github.com/kcl-lang/cli