Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ArgumentReferences property name comment in kclrun crd #128

Closed
ron1 opened this issue Sep 4, 2024 · 1 comment · Fixed by #132
Closed

Fix ArgumentReferences property name comment in kclrun crd #128

ron1 opened this issue Sep 4, 2024 · 1 comment · Fixed by #132
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ron1
Copy link
Contributor

ron1 commented Sep 4, 2024

flux-kcl-controller/api/v1alpha1/kclrun_types.go

Line 130 in 0a60441

// ConfigReference holds references to ConfigMaps and Secrets containing
should be ArgumentReferences not ConfigReference.
@Peefy
Copy link
Contributor

Peefy commented Sep 4, 2024

Good Catch! PRs welcome! ❤️

@Peefy Peefy added good first issue Good for newcomers help wanted Extra attention is needed labels Sep 4, 2024
@ron1 ron1 mentioned this issue Sep 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
2 participants
@ron1 @Peefy