Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add more Kustomization .spec fields to KCLRun resource #112

Closed
ron1 opened this issue Aug 16, 2024 · 7 comments
Closed

[Feature] Add more Kustomization .spec fields to KCLRun resource #112

ron1 opened this issue Aug 16, 2024 · 7 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ron1
Copy link
Contributor

ron1 commented Aug 16, 2024

Feature Request

Is your feature request related to a problem? Please describe:
I'm trying to replace a set of inter-dependent Kustomization resources with KCLRun resources. In order to do so, I need KCLRun resources to support additional Kustomization .spec fields including:

  • dependsOn
  • suspend
  • healthChecks
  • wait
  • postBuild
  • retryInterval
  • interval
  • prune
@Peefy Peefy added good first issue Good for newcomers help wanted Extra attention is needed labels Aug 16, 2024
@Peefy
Copy link
Contributor

Peefy commented Aug 16, 2024

Thanks for the feedback. We will gradually inherit more from the kustomization controller because many upstream APIs are internal, so it requires some effort. It would be great if you could participate in it. ❤️

More Issues and PRs are also welcome.

@Peefy
Copy link
Contributor

Peefy commented Aug 20, 2024

Closed by #114, #115, #116, #117, #118 and #119

It should be noted that the postbuild parameter is not implemented in these PRs because it is a unique behavior of kustomize build. For KCL, it is replaced by KCL's compilation configuration: #117

@Peefy Peefy closed this as completed Aug 20, 2024
@ron1
Copy link
Contributor Author

ron1 commented Aug 21, 2024

@Peefy Thanks much for your efforts to implement this feature. Would you be able to provide an example of how kcl's compilation configuration feature can replace the Kustomization post build substitute from feature? For example, where a variable is replaced from a field in a pre-existing ConfigMap.

@Peefy
Copy link
Contributor

Peefy commented Aug 21, 2024

@ron1

I will provide more examples and some reference documents latter.

@ron1
Copy link
Contributor Author

ron1 commented Aug 21, 2024

Thanks again!

@Peefy
Copy link
Contributor

Peefy commented Sep 4, 2024

image
In the flux-kcl-controller v0.5.0

We can set the argumentsReference field from ConfigMap and Secret for the option function in the KCL code.

@ron1
Copy link
Contributor Author

ron1 commented Sep 4, 2024

Perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants