Remove duplicate code that generates s-forms from s-pipes scrips and document it

[blcham]

When implementing #26 we found out duplicated code alternative implementation of cz.cvut.spipes.transform.Transformer.

A/C:

• we should document how spipes2s-forms Transformer.script2form transformation works (just include/modify diagram Figure 26: Module configuration form generation in 2018-Doroshenko-Yan-thesis.pdf into the s-pipes/s-forms-modulepipes-forms folder)
• There should not be a duplicate implementation of transformation (the other one is in s-pipes-editor) -- it should be removed either from s-pipes or from s-pipes-editor
• Revise differences in Transformer implementations.

Tasks

Preview Give feedback

1. Revise differences in Transformer.functionToForm implementations #34
   +0
2. Revise differences in Transformer.form2Script implementations #35
   +0

[kostobog]

Overview of relevant changes between new and old implementations

1. (old implementation) cz.cvut.spipes.transform.TransformerImpl in s-pipes-forms module in cvut-kbss/s-pipes
2. (new implementation) og_spipes.service.FormService.OwnTransformer in cvut-kbss/s-pipes-editor

Overview of Functional Changes

• form2Script - contains functional changes

  • + Documentation comment on method
  • + Log message
  • + add parenthesis in lambda
  • * changes in implementation - ~34 lines, + ~40 lines

• functionToForm - contains functional changes

  • * changes in implementation - 4 lines +6 lines

• + handleFormUpdate added in new implementation

  • 2 usages in form2script (total usages 2)

• isSupportedAnon - no functional changes, not used in new implementation

Overview of Non Functional Changes

• + Log messages
• + using inline package for s-pipes-forms Vocabulary class
• + commented new code
• * formatting
• + Documentation comment on method
• + add parenthesis in lambda