Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Records in record list should be links #79

Open
blcham opened this issue Jan 25, 2024 · 5 comments · Fixed by #132
Open

Records in record list should be links #79

blcham opened this issue Jan 25, 2024 · 5 comments · Fixed by #132
Assignees

Comments

@blcham
Copy link

blcham commented Jan 25, 2024

It should be possible to open record to a new tab from record-list. Note that it was already implemented before (see git history).

@blcham blcham assigned LaChope and unassigned LaChope Jan 25, 2024
@LaChope
Copy link
Collaborator

LaChope commented Mar 20, 2024

I cannot find anything in history (no branch or specific commit), was it pushed?

@blcham
Copy link
Author

blcham commented Mar 20, 2024

I just wanted to say that it used to work long time ago, so when looking to a history of a relevant file you should see it (but even if you find it I am not sure if it helps).

You would definitely see it in git history of RecordRow.js. Most likely, it commit 4f015b8ae1ae3de92aaf10e2278fd479f61946f2, where it stopped working.

@blcham
Copy link
Author

blcham commented Mar 25, 2024

Here is related issue #125

@LaChope
Copy link
Collaborator

LaChope commented Apr 9, 2024

Re-opening as reverted (20cdcb0) because tests are failing: Error: Uncaught [Error: Invariant failed: You should not use <Link> outside a <Router>].

@LaChope LaChope reopened this Apr 9, 2024
@LaChope LaChope removed their assignment Apr 19, 2024
@blcham
Copy link
Author

blcham commented May 15, 2024

Currently this is not that relevant, thus putting it to TODO state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants