Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser Testing #72

Open
winghimjns opened this issue Dec 6, 2017 · 3 comments
Open

Browser Testing #72

winghimjns opened this issue Dec 6, 2017 · 3 comments

Comments

@winghimjns
Copy link

Hi Kabir,

I used Wing in one project, a simple one page site. I left it for a while and just tested it yesterday in iPad's browser. Not sure if it's the problem in my code or wing's.

Appreciate that this framework is lightweight but gets everything basic. I tried this framework because sometimes when I use bootstrap I just need the html reset, grid system and couple of variables and mixins. It's good to have less predefines and keep the most frequent use features.

But seems like the grid system is not work properly in iPad devices. What I saw is each col col-*, first one is. col col-9 filled 100% width of the row, and the 2nd one col col-3 is started to be overflowed.

It's important to note that the browser I was using is out of date. But I don't find any documentations about the browser compatibility.

Will browser testing be in the schedule? Or shall we make a browser compatibility list by checking the modern features we are using especially flex?

Cheers,

Wing Him

@kbrsh
Copy link
Owner

kbrsh commented Dec 6, 2017

Hey,

I appreciate the detailed response.
The col classes aren't meant to be used together, which looks like the main problem here. col resizes to fill the rest of the space, while col-* fills up a fixed amount of width.

Try using the appropriate col classes and see if that works. I might add browser tests for this type of stuff one day as well.

@winghimjns
Copy link
Author

Thanks for the details, I think I used it incorrectly.

I just have a look to the unminified production .css again. And realist that the one I am using on unpkg.com (https://unpkg.com/[email protected]/dist/wing.css) is not the same one as this repository's master especially the grid system, even with the same version code 1.0.0-beta.

The one here is using width attr for col-* and the unpkg one is using flex attr.

Is this an issue?

Thanks

@kbrsh
Copy link
Owner

kbrsh commented Dec 7, 2017

Nope, it's not an issue. The version on this repository is the current development of 1.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants