fixes overly rounded select #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Sorry for the late response—thanks for being patient. Looks good, and I've tried this solution before, but I'm worried about the weight it adds to Wing. Do you think an extra kb is worth fixing a rounded select? Would love to know your thoughts on it and how this can be further optimized. Thanks again. |
|
Thanks for your honest reply. Actually I've missed to check the weight. |
|
With 991155f I managed to reduce the increase to 0.51 kb and do some stylistic adjustments. In any case, I learned something, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will resolve #69 and is tested in chrome, safari (also mobile), ff and edge (virtual)