max_scan1() error message with lodcolumn out of range

- Fixes Issue rqtl#132.
kbroman · Sep 27, 2019 · 63ba6d1 · 63ba6d1
1 parent f088858
commit 63ba6d1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/NEWS.md b/NEWS.md
@@ -71,6 +71,9 @@
 - In `max_scan1()`, treat the case that the input has no column names.
   [Fixes Issue #133.]
 
+- `max_scan1()` was giving a messed up error message if `lodcolumn`
+  was out of range. [Fixes Issue #132.]
+
 
 ## qtl2 0.20 (2019-06-03)
 

diff --git a/R/max_scan1.R b/R/max_scan1.R
@@ -73,7 +73,7 @@ max_scan1 <-
         lodcolumn <- lodcolumn_num
     }
     if(lodcolumn < 1 || lodcolumn > ncol(scan1_output)) {
-        stop("column [", lodcolumn, "] out of range (should be in 1, ..., ", ncol(lod), ")")
+        stop("column [", lodcolumn, "] out of range (should be in 1 - ", ncol(scan1_output), ")")
     }
 
     if(is.null(map)) {