Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArgRequiredElseHelp has lower priority than missing required arguments #895

Closed
iKevinY opened this issue Mar 11, 2017 · 5 comments
Closed

ArgRequiredElseHelp has lower priority than missing required arguments #895

iKevinY opened this issue Mar 11, 2017 · 5 comments
Assignees
@kbknapp
Labels
A-parsing Area: Parser's logic and needs it changed somehow. C-bug Category: Updating dependencies

Comments

@iKevinY
Copy link

iKevinY commented Mar 11, 2017 •
edited
Loading

As of v2.20, ArgRequiredElseHelp doesn't properly take precedence over missing required arguments (the same issue as described in #362). This was working as expected in v2.19.3.

Affected Version of clap

v2.20.0, v2.20.5, 814b126

Expected Behavior Summary

Full help page is printed when no arguments are provided.

Actual Behavior Summary

error: The following required arguments were not provided:
@kbknapp
Copy link
Member

kbknapp commented Mar 11, 2017

Thanks for reporting this! Could you check if current master (what will be 2.21) is also affected?

@iKevinY
Copy link
Author

iKevinY commented Mar 11, 2017

Seems like current master is also affected (tested under 814b126).

@kbknapp
Copy link
Member

kbknapp commented Mar 11, 2017

Ok thanks!

@kbknapp kbknapp self-assigned this Mar 11, 2017
@kbknapp kbknapp added C: errors A-parsing Area: Parser's logic and needs it changed somehow. C-bug Category: Updating dependencies labels Mar 11, 2017
@homu homu closed this as completed in 74b751f Mar 12, 2017
@kbknapp
Copy link
Member

kbknapp commented Mar 12, 2017

This is fixed in 2.21.1 om crates.io

@iKevinY
Copy link
Author

iKevinY commented Mar 12, 2017

Awesome, thanks for the speedy fix! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kbknapp kbknapp

Labels
A-parsing Area: Parser's logic and needs it changed somehow. C-bug Category: Updating dependencies
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iKevinY @kbknapp