Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thread 'main' has overflowed its stack #68

Closed
steveklabnik opened this issue Sep 21, 2017 · 9 comments
Closed

thread 'main' has overflowed its stack #68

steveklabnik opened this issue Sep 21, 2017 · 9 comments

Comments

@steveklabnik
Copy link

This happens whenever I run cargo-outdated in the Rust repository's src directory.

Rust 1.20.

@Frederick888
Copy link
Collaborator

@steveklabnik I tested it myself and got

⇒  cargo outdated -v
  Parsing... current workspace
Resolving... current workspace
error: manifest path `/home/frederick/Programming/Rust/rust/src/Cargo.toml` is a virtual manifest, but this command requires running against an actual package in this workspace

...since #58 looping through workspace members is not supported yet. Which version of cargo-outdated were you using?

@steveklabnik
Copy link
Author

> cargo outdated --version
cargo-outdated v0.4.0

I had just run 'cargo-install'.

@Frederick888
Copy link
Collaborator

Frederick888 commented Sep 22, 2017

@steveklabnik Well, I don't have the permission to publish the new 0.5.0 to crates.io, so you could only manually clone this repo and run cargo install --path . -f.

But even though since I haven't got time to do #58 , it cannot be used on a virtual manifest out of the box yet. Maybe a simple Bash script could do the job for now.

@steveklabnik
Copy link
Author

I don't have the permission to publish the new 0.5.0 to crates.io,

Ah interesting, thanks! (Also, cargo install supports a --git flag, so that'd be even easier to install).

This seems bad though; what happened? I really love cargo-outdated.

How hard do you think #58 is?

@Frederick888
Copy link
Collaborator

Frederick888 commented Sep 22, 2017

@steveklabnik @kbknapp has been a bit busy recently, let's just wait him to be back patiently :)

I don't think #58 would be too hard. Basically it would be a matter of replacing workspace.current() calls with some workspace-member-aware logics and finally looping through all the members to compare dependency trees and print the results out... some extra work will be needed to reuse the temporary workspace though.

@kbknapp
Copy link
Owner

kbknapp commented Sep 22, 2017

My apologies! Yeah my time has been monopolized lately, @Frederick888 I'll add you so you can publish new version as well.

@kbknapp
Copy link
Owner

kbknapp commented Sep 22, 2017

@Frederick888 you should be able to publish new versions to crates.io now as well. Aside, feel free to add yourself to the authors array as well, I think you've earned it 😉

@steveklabnik
Copy link
Author

@steveklabnik @kbknapp has been a bit busy recently, let's just wait him to be back patiently :)

Ah, it's all good! Everyone needs some time off. Looks like @kbknapp came back briefly between now and then; thank you for one of the most useful cargo commands!

@Frederick888
Copy link
Collaborator

Frederick888 commented Sep 23, 2017

@kbknapp Many thanks! I have just published v0.5.1 with some minor changes since the last release.

I think I'm going to close this issue in support of #58. And by the way, I have assigned #58 with a P1 label and I'd work on it first if I can make some time. My uni assessments are killing me right now lol...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants