Skip to content
This repository has been archived by the owner on Apr 30, 2024. It is now read-only.

problem with uploading ico files as asset #6

Open
MichaelTorfs opened this issue May 27, 2009 · 2 comments
Open

problem with uploading ico files as asset #6

MichaelTorfs opened this issue May 27, 2009 · 2 comments

Comments

@MichaelTorfs
Copy link

Hi,

I'm not a coder, so excuse me if I sound a but untechnical.

We have 2 sites running, one with the paperclipped extension checked out at April 2nd, the other one cheched out at May 17th. The last one has a bug (or I do something wrong).

I create 2 assets. favicon.png and favicon.ico, all settings are default, title I put the same as the filename, including extension.

In my layout I have the following in my head part:
<link rel="Shortcut Icon" href=<r:assets:url title="favicon.ico" /> type="image/x-icon" />
<link rel="icon" href=<r:assets:url title="favicon.png" /> type="image/png" />

It is resolved in the page source on the website as follows (checkout of May 17th) with the bug:
link type="image/x-icon" href="/images/assets/doc_original.png" rel="Shortcut Icon"/
link type="image/png" href="/assets/5/favicon.png" rel="icon"/

It is resolved in the page source on the website as follows (checkout of April 2nd):
link type="image/x-icon" href="/assets/1/favicon.ico" rel="Shortcut Icon"/
link type="image/png" href="/assets/2/favicon.png" rel="icon"/

I think something goes wrong in in the assets.rb model, line 90 (BTW our setting is default: original)

@bastilian
Copy link

Can you check if the file gets saved on the server?
Also what browser are you using?

@MichaelTorfs
Copy link
Author

Hi, sorry, we reinstalled radiant with a copy of the April 2nd paperclipped version we still had. I am using firefox 3.0.10.
If really needed I can try to install locally.
Can you reproduce it? Or did not try yet?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants