Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Named formatting: use name if value is missing #77

Merged
merged 1 commit into from
Oct 29, 2016
Merged

Named formatting: use name if value is missing #77

merged 1 commit into from
Oct 29, 2016

Conversation

SebastianS90
Copy link
Contributor

Consider the locales

{
    foo: 'This {argument} is {missing}'
}

and use them as $t('foo', {argument: 'test'}).

Old behavior: 'This test is '
New behavior: 'This test is {missing}'

@kazupon kazupon merged commit a0cc343 into kazupon:dev Oct 29, 2016
@SebastianS90 SebastianS90 deleted the named-formatting-placeholder branch October 29, 2016 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SebastianS90 @kazupon