Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception when using unit number formatting #751

Closed
wants to merge 2 commits into from
Closed

Fix exception when using unit number formatting #751

wants to merge 2 commits into from

Conversation

simonjodet
Copy link
Contributor

Suggested fix for #750

@codecov-io
Copy link

codecov-io commented Dec 10, 2019

Codecov Report

Merging #751 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #751   +/-   ##
=======================================
  Coverage   96.26%   96.26%           
=======================================
  Files          10       10           
  Lines         803      803           
=======================================
  Hits          773      773           
  Misses         30       30
Impacted Files Coverage Δ
src/util.js 98.3% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc110cd...0a848e5. Read the comment docs.

@kazupon
Copy link
Owner

kazupon commented Dec 10, 2019

@simonjodet
Thank you for your PR!

I'll build to release vue-i18n.
Could you revert this commit, please?

@kazupon kazupon closed this in 194b801 Dec 18, 2019
@kazupon
Copy link
Owner

kazupon commented Dec 18, 2019

@simonjodet
I've fixed with this commit

Thank you for your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants