Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8.10.0 with Breaking changes #736

Closed
Roriz opened this issue Nov 6, 2019 · 2 comments
Closed

v8.10.0 with Breaking changes #736

Roriz opened this issue Nov 6, 2019 · 2 comments

Comments

@Roriz
Copy link

Roriz commented Nov 6, 2019

vue-i18n version

v8.10.0

Description

On version v8.10.0 we merge the PR: #533, with this new feature, a project with an old version can be broke without warning or error. In my opinion, this feature is very useful but is a breaking change.
I work on a project with very large keys, when these keys surpass 80 characters we using a string template and brake line to fit on linter rule.

Reproduction Link

https://jsfiddle.net/e4ms1gy7/

Expected Link

https://jsfiddle.net/e4ms1gy7/1/

Steps to reproduce

Use a break line or space between keys

What is Expected?

Normally translate

What is actually happening?

Translate is missing

Sugestion

We can change the release message to:

:star: New Features
number: i18n-n functional component (#541) by @bponomarenko (b33579d), closes #541

:boom: Breaking changes
path: Keypath should parse if sub path contains spaces. (#533) by @exoego (640daaf), closes #533

:zap: Improvements
number: support data fall through in i18n-n (#545) (71cadbf), closes #545
memo docs
vuepress: translate documents for chinese (#536) by @xuhongbo (ccf29f8), closes #536 #531 #1 #533 #540 #541 #1 #2

Or we can rollback this feature and merge again on next major version

@lucassonsinlima
Copy link

Any updates for this? I'm facing the same issue as @Roriz

@exoego
Copy link
Collaborator

exoego commented Apr 18, 2020

Sorry about the accidental breaking change.
It was unpredictable for me that someone is using string template to avoid linter error on long message key.

How about migrating your code using concatenation instead, something like

{{ $t("very."
    + "long.key") }}

@kazupon kazupon closed this as completed Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants