Custom Message Formatter #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow for register a custom message formatter function with `Vue.config.i18nFormatter` for more flexibility in formatting messages.
jvmccarthy
changed the title
|
Looks like the build failure is due to issues with sauce labs browsers not starting and that the lines I committed were covered, so I'm not sure what the difference in code coverage is. Let me know how I can help, thanks! |
kazupon
approved these changes
Sep 24, 2016
|
Thanks @kazupon for merging this in. I was just reviewing the docs again and noticed a minor typo on the API page. It should be 'custom' instead of 'customer'. My apologies. I don't think it's worth another pull request for such a minor commit. If you could tweak the file, I'd appreciate it. Here's the changes I'm referring to, jvmccarthy@628c58c Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for registering a custom message formatter function with
Vue.config.i18nFormatterfor more flexibility in formatting messages.I have a requirement to use the extended Java MessageFormat spec for generically including support in the string format for dates and times. For example, imagine a message like this,
maintenanceWarning: 'The site will be undergoing maintenance starting {0,date} at {0,time}.'I plan to support localizing this client side using moment.js, but I need extra pluggability from vue-i18n to make this possible. By allowing for a custom formatter, vue-i18n offers greater flexibility to user needs without overloading vue-18n itself with multiple formats.
Thank you for your efforts on vue-i18n!