Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for Vue.extend vue-i18n instance #420

Merged
merged 1 commit into from
Sep 3, 2018

Conversation

jaredzhu1993
Copy link
Contributor

To fix #200 , now we can use

const i18n = new VueI18n({ ... })
const Constructor = Vue.extend({ i18n })
const vm = new Constructor({ ... }).$mount()

@codecov-io
Copy link

codecov-io commented Aug 31, 2018

Codecov Report

Merging #420 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev     #420      +/-   ##
=========================================
+ Coverage   95.9%   95.91%   +<.01%     
=========================================
  Files          9        9              
  Lines        635      636       +1     
=========================================
+ Hits         609      610       +1     
  Misses        26       26
Impacted Files Coverage Δ
src/install.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 170f691...13ed048. Read the comment docs.

Copy link
Owner

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍
Thanks!

@kazupon kazupon merged commit a60ea8b into kazupon:dev Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue.extend does not accept a VueI18n class instance as i18n option
3 participants