Add pluralization feature to directive #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
btw I think this will fail 3 unit tests however those same three tests failed in the fork I took, ie. those tests are not related to the scope of this PR. |
Codecov Report
@@ Coverage Diff @@
## dev #304 +/- ##
==========================================
+ Coverage 96.11% 96.12% +0.01%
==========================================
Files 9 9
Lines 617 620 +3
==========================================
+ Hits 593 596 +3
Misses 24 24
Continue to review full report at Codecov.
|
kazupon
requested changes
Mar 6, 2018
|
OK done |
|
Thanks! |
|
Yeah I did that already |
kazupon
requested changes
Mar 9, 2018
package-lock.json
Outdated
| @@ -1,19 +1,9 @@ | |||
| { | |||
| "name": "vue-i18n", | |||
| "version": "7.4.2", | |||
There was a problem hiding this comment.
Please revert package-lock.json changing. 🙏
kazupon
approved these changes
Mar 10, 2018
manniL
pushed a commit
to manniL/vue-i18n
that referenced
this pull request
Mar 10, 2018
… by @SirLamer * Add "choice" quantity support to v-t directive * Add unit tests * Revert dist changes
This was referenced Mar 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds pluralization support to the v-t direction using the additional property "choice". The implementation is slightly sloppy but lightweight in that it makes use of the existing division between $t and $tc. The main reason I wanted this was to take advantage of the performance optimization opportunity afforded by the directive use case.
I have included unit tests but I have not updated the documentation since I am not certain of your workflow structure you're using for docs.
Sorry I committed the dist file before seeing that your contributing guidelines ask that it not be committed, as a tip for the future I suggest you add the dist folder to .gitignore and have GitHub compile the dist folder for you. In this case you'll probably have to merge the PR and then run a recompile and merge that in to capture any other changes since my fork on March 4th.