Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow type augmentation #273

Merged
merged 2 commits into from
Jan 10, 2018
Merged

Allow type augmentation #273

merged 2 commits into from
Jan 10, 2018

Conversation

CKGrafico
Copy link
Contributor

This was the only way that I have found to allow Module Augmentation

example:

declare module 'vue-i18n/types/index' {
  // Declare augmentation for Vue-i18n
  interface IVueI18n {
    path: any;
  }
}

@codecov-io
Copy link

codecov-io commented Jan 9, 2018

Codecov Report

Merging #273 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #273   +/-   ##
=======================================
  Coverage   96.09%   96.09%           
=======================================
  Files           9        9           
  Lines         615      615           
=======================================
  Hits          591      591           
  Misses         24       24

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51bfca3...11e5b72. Read the comment docs.

types/index.d.ts Outdated
static version: string;
static availabilities: VueI18n.IntlAvailability;
declare class VueI18n {
constructor(options?: VueI18n.I18nOptions)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please adjust the tab indint to 2 space. 🙏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouch!

@kazupon kazupon merged commit 4371344 into kazupon:dev Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants