Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE11 Incompatible 'for...in' in VueI18n.prototype._link #188

Merged
merged 1 commit into from
Jun 30, 2017

Conversation

632781460
Copy link
Contributor

@632781460 632781460 commented Jun 29, 2017

vue-i18n version

7.0.3

add method to Array.prototype
VueI18n.prototype._link throw error "substr is undefined "
fix: use hasOwnProperty filter the pollyfill array method

  // Match all the links within the local
  // We are going to replace each of
  // them with its translation
  var matches = ret.match(/(@:[\w\-_|.]+)/g);
  for (var idx in matches) {
    if (matches.hasOwnProperty(idx)) {
      // logical code
    }
  }

@codecov-io
Copy link

codecov-io commented Jun 29, 2017

Codecov Report

Merging #188 into dev will decrease coverage by 0.18%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev     #188      +/-   ##
=========================================
- Coverage   95.8%   95.62%   -0.19%     
=========================================
  Files          8        8              
  Lines        501      503       +2     
=========================================
+ Hits         480      481       +1     
- Misses        21       22       +1
Impacted Files Coverage Δ
src/index.js 97.35% <50%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b929bd5...8b1bd99. Read the comment docs.

@kazupon kazupon merged commit d3b308b into kazupon:dev Jun 30, 2017
@kazupon
Copy link
Owner

kazupon commented Jun 30, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants