Skip to content

Commit

Permalink
🐛 bug(index): Fix #515 empty string not returning true (#525) by @kim…
Browse files Browse the repository at this point in the history
…uraz

Closes #515
  • Loading branch information
kimuraz authored and kazupon committed Mar 3, 2019
1 parent ddaad4c commit 396c5ca
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ export default class VueI18n {

this._exist = (message: Object, key: Path): boolean => {
if (!message || !key) { return false }
if (this._path.getPathValue(message, key)) { return true }
if (!isNull(this._path.getPathValue(message, key))) { return true }
// fallback for flat key
if (message[key]) { return true }
return false
Expand Down
6 changes: 6 additions & 0 deletions test/unit/issues.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -687,4 +687,10 @@ describe('issues', () => {
assert.strictEqual(res, 'Hello World {text}')
})
})

describe('#515', () => {
it('$te should return true for empty string', () => {
assert.strictEqual(vm.$te('message.empty'), true)
})
})
})

0 comments on commit 396c5ca

Please sign in to comment.