Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pidMode mapping to tdToTaskDefinitionInput function #715

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

ch1aki
Copy link
Contributor

@ch1aki ch1aki commented Jul 16, 2024

When converting remoteTaskDef to TaskDefinitionInput, pidMode is not mapped, causing persistent diffs due to missing information.

@ch1aki ch1aki changed the title Add pidMode and IPCMode mapping to tdToTaskDefinitionInput function Add pidMode mapping to tdToTaskDefinitionInput function Jul 16, 2024
@ch1aki ch1aki marked this pull request as ready for review July 16, 2024 13:29
@fujiwara fujiwara merged commit dee9c2b into kayac:v2 Jul 17, 2024
2 checks passed
fujiwara added a commit that referenced this pull request Jul 17, 2024
@fujiwara
Copy link
Contributor

@ch1aki Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants