Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Origin library to project #82

Open
kaveh808 opened this issue Sep 1, 2022 · 5 comments
Open

Add Origin library to project #82

kaveh808 opened this issue Sep 1, 2022 · 5 comments

Comments

@kaveh808
Copy link
Owner

kaveh808 commented Sep 1, 2022

@JMC-design

https://git.mfiano.net/mfiano/origin
https://quickdocs.org/origin

@kaveh808 kaveh808 added this to kons-9 Sep 1, 2022
@JMC-design
Copy link
Contributor

So I've already got a branch working with my point protocol, with all point stuff package prefixed with p: so I can just copy that over and have a slight indirection in a P: package wrapping origin, or I can just change those prefixes to origin.vec3 and it should be good to go. or maybe that should be origin.vec4 to be ready for transforms or else we cant use them as is.
I think some indirection might be nice in case there's a need to swap to another point/vector library.

@kaveh808
Copy link
Owner Author

kaveh808 commented Sep 2, 2022

Sounds good. Let's put the wrapper around origin.vec4.

@JMC-design
Copy link
Contributor

sure thing, will do tomorrow morning.

@JMC-design
Copy link
Contributor

So this isn't quite that simple. origin, in it's being 'correct', doesn't do things like cross-products of vec4's, or if you want to scale by number it will scale w, so it's like you need some functions from vec3 some from vec4.
I remember mfiano expressing frustration over separate functions for each type, this might be why mfiano created gfxmath after this and then completely jumped ship to julia.
In general I haven't seen any visible difference between what's there, my generic point protocol, or 3d-vectors.

@kaveh808
Copy link
Owner Author

kaveh808 commented Sep 2, 2022

In that case let's wrap around vec3. That will do us fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants