Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio Triggers by zone #194

Open
WaringMcMarrin opened this issue Jul 24, 2024 · 3 comments
Open

Audio Triggers by zone #194

WaringMcMarrin opened this issue Jul 24, 2024 · 3 comments
Labels
enhancement New feature or request low priority

Comments

@WaringMcMarrin
Copy link

Having the ability to enable or disable audio triggers by zone would be helpful for improving performance by reducing the amount of triggers needing to be checked and could reduce triggers that get fired when they shouldn't be.

Settings for an induvial trigger and can set up defaults for newly created or imported triggers

Settings on trigger:

  1. All zones enabled by default
  2. Select zone(s) that the trigger can fire in
  3. Select expansion(s) that the trigger can fire in (This will be a pre setup list that comes with the app)
  4. Select zone(s) that the trigger won't fire in
  5. Select expansion(s) that the trigger won't fire in (This will be a pre setup list that comes with the app)

Settings for all triggers in a folder unless overridden by a trigger in that folder.

Example stricture
Raids -> All zones
Laurion's Song -> LS zones
Bidil -> raid zone
Final Fuge -> raid zone
Night of Shadows -> NoS zones
Deepshade - > raid zone
Direfall Pass -> raid zone

Settings on folder

  1. All zones enabled by default
  2. Select zone(s) that the trigger can fire in
  3. Select expansion(s) that the trigger can fire in (This will be a pre setup list that comes with the app)
  4. Select zone(s) that the trigger won't fire in
  5. Select expansion(s) that the trigger won't fire in (This will be a pre setup list that comes with the app)
@kauffman12 kauffman12 added enhancement New feature or request low priority labels Jul 24, 2024
@kauffman12
Copy link
Owner

Do you know of anyone having performance issues that isn't running on an old laptop or something? A decent CPU should be OK even if there's 10k triggers. Regex is really fast in this version. I only warn people to have less for active triggers. Things may slow down if your overlays getting overwhelmed with triggers being matched.

@WaringMcMarrin
Copy link
Author

I don't know how much of an issue it is with EQ Log Parser but I do know it is an issue with GINA. I figured a feature like this would be good for performance and also to reduce false triggers for things that share the same message but don't apply in all zones.

@kauffman12
Copy link
Owner

Yeah something like that could be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority
Projects
None yet
Development

No branches or pull requests

2 participants