Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong output in multi-array set #57

Closed
anuj1405 opened this issue Dec 6, 2018 · 6 comments · Fixed by #68
Closed

Wrong output in multi-array set #57

anuj1405 opened this issue Dec 6, 2018 · 6 comments · Fixed by #68
Labels
bug ready to close Issue reporter will close when satisfied
Milestone

Comments

@anuj1405
Copy link

anuj1405 commented Dec 6, 2018

This is the JSON:

[{
   "orderId": "111-8763976-4506632",
   "version3.0": {
      "customizationInfo": {
         "surfaces": [
            {
               "name": "Angled Above Handle",
               "areas": [
                  {
                     "name": "Choose Knife",
                     "optionImage": ""
                  }
               ]
            },
            {
               "name": "Right Face",
               "areas": [
                  {
                     "name": "Right Face Engraving",
                     "optionImage": "https://m.media-amazon.com/images/S/pc-vendor-gallery-prod/A17JMGFJQ7S29T/options/2018-08-24/ef64d10d-7668-42f1-a0ea-6c9971c13a0f.png"
                  }
               ]
            }
         ]
      }
   }
}]

and the output we are getting is

screen shot 2018-12-07 at 12 52 52 am

See the column "customizationInfo.surfaces.areas.optionImage". The value should be there on the 2 row instead of first

Thanks

@kaue
Copy link
Owner

kaue commented Dec 6, 2018

@anuj1405 this is a feature. please check #22
You should use fillGaps: true to get the optionImage filled in both rows

@kaue
Copy link
Owner

kaue commented Dec 6, 2018

Oh now i see whats happening, indeed this is a bug. and its prob caused by #22

@kaue
Copy link
Owner

kaue commented Dec 6, 2018

We are always looking for new contributors, you want to help us fix this issue? feel free to start a PR on this =)

@kaue kaue changed the title Wrong output Wrong output in multi-array set Dec 6, 2018
@markwynter
Copy link

I've got similar problem. I've set FillGaps = true, but subscriber1 CustomFields values not shifting down in CSV. The JSON data is from Campaign Monitor API. Simple input and output files attached to demonstrate problem. What support do you need to fix the bug?
Archive_CM.zip

@toxuin
Copy link

toxuin commented Jun 18, 2019

This is still broken. Renders jsonexport unusable for my usecase.

@kaue kaue mentioned this issue May 23, 2020
@kaue
Copy link
Owner

kaue commented May 23, 2020

@anuj1405 @markwynter @toxuin I introduced a new option to jsonexport called fillTopRow that should be desabled by default. (#68)
After this PR gets merged you guys should be able to get the expected results.

@kaue kaue added ready to close Issue reporter will close when satisfied and removed help wanted labels May 23, 2020
@kaue kaue added this to the 3.0.0 milestone May 23, 2020
@kaue kaue mentioned this issue May 23, 2020
3 tasks
@kaue kaue closed this as completed in 462b330 May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ready to close Issue reporter will close when satisfied
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants