This repository has been archived by the owner on May 12, 2021. It is now read-only.
cgroups: fix failed to remove sandbox cgroup #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandbox cgroup use V1NoConstraints, this only create memory subsystem, but when delete, load parent cgroup always use `cgroups.V1`, so other subsystem path can not be find, sandbox cgroup can not be deleted. Fixes: #1263 Signed-off-by: Ace-Tang <[email protected]>
|
Hey, @devimc , could you please to check if this is correct |
|
@Ace-Tang sure I'll review it, changing state to do-not-merge and assigning it to me |
|
@Ace-Tang you're right, good catch! |
devimc
approved these changes
Feb 21, 2019
|
/test |
|
@kata-containers/runtime one more review |
jcvenegas
approved these changes
Feb 21, 2019
|
good finding! lgtm |
|
Thank for review @devimc @jcvenegas |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sandbox cgroup use V1NoConstraints, this only create memory subsystem,
but when delete, load parent cgroup always use
cgroups.V1, so othersubsystem path can not be find, sandbox cgroup can not be deleted.
Fixes: #1263
Signed-off-by: Ace-Tang [email protected]