Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

runtime unit-test: FAIL Invalid proxy parameters #1312

Closed
jcvenegas opened this issue Mar 1, 2019 · 0 comments
Closed

runtime unit-test: FAIL Invalid proxy parameters #1312

jcvenegas opened this issue Mar 1, 2019 · 0 comments

Comments

@jcvenegas
Copy link
Member

Description of problem

make test will result in a failing test.

time="2019-03-01T15:15:22-06:00" level=error msg="failed to start proxy"
error="Invalid proxy parameters {id:foobar path: agentURL: consoleURL:
logger:0xc000$ d8e60 debug:false}" params="{foobar 0xc0000d8e60 false}"
proxy type=invalidProxyType source=virtcontainers vm=foobar FAIL
github.com/kata-containers/runtime/virtcontainers 1.049s make: ***
[Makefile:532: go-test] Error 1

Expected result

make test passes

Actual result

(replace this text with details of what actually happened)


(replace this text with the output of the kata-collect-data.sh script, after
you have reviewed its content to ensure it does not contain any private
information).

jcvenegas added a commit to jcvenegas/runtime that referenced this issue Mar 1, 2019
Simply empty string proxy type handling and
cast invalid proxy type to ProxyType

Fixes: kata-containers#1312

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
jcvenegas added a commit to jcvenegas/runtime that referenced this issue Mar 1, 2019
Simplify empty string proxy type handling and cast invalid proxy type to
ProxyType.

Fixes: kata-containers#1312

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
jcvenegas added a commit to jcvenegas/runtime that referenced this issue Mar 5, 2019
Simplify empty string proxy type handling and cast invalid proxy type to
ProxyType.

Fixes: kata-containers#1312

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
alicefr pushed a commit to alicefr/runtime that referenced this issue Mar 6, 2019
Simplify empty string proxy type handling and cast invalid proxy type to
ProxyType.

Fixes: kata-containers#1312

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant