Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Makefile doesn't provide default QEMUCMD or FCCMD #1169

Closed
bryteise opened this issue Jan 24, 2019 · 0 comments
Closed

Makefile doesn't provide default QEMUCMD or FCCMD #1169

bryteise opened this issue Jan 24, 2019 · 0 comments

Comments

@bryteise
Copy link
Contributor

Description of problem

export GOPATH="${PWD}/gopath/"
mkdir -p "${GOPATH}/src/github.com/kata-containers/"
ln -sf "${PWD}" "${GOPATH}/src/github.com/kata-containers/runtime"
cd "${GOPATH}/src/github.com/kata-containers/runtime"
make SKIP_GO_VERSION_CHECK=y

Expected result

build succeeds

Actual result

build fails with a message about none of QEMUCMD or FCCMD being provided.

bryteise added a commit to bryteise/runtime that referenced this issue Jan 24, 2019
As arch detection isn't being done and KNOWN_HYPERVISORS was only
being populated via environment variable settings (and is a runtime
rather than build time dependency anyway) just provide a set of
defaults that can be overridden as needed at build time.

This will also cause any hypervisor configuration to always be
installed.

Fixes kata-containers#1169

Signed-off-by: William Douglas <[email protected]>
egernst pushed a commit to egernst/runtime that referenced this issue Feb 26, 2019
Architecture-dependent settings were not being populated when GOPATH
was set. This change ensures they are always set.

Fixes kata-containers#1169

Signed-off-by: William Douglas <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant