diff --git a/ingredients/seqlab_mod.py b/ingredients/seqlab_mod.py index 74b7820..aa66aa7 100644 --- a/ingredients/seqlab_mod.py +++ b/ingredients/seqlab_mod.py @@ -622,7 +622,26 @@ def load_artifacts(self, model) -> None: with tarfile.open(self.artifacts_path, 'r:gz') as f: members = [member for member in f.getmembers() if member.name in artifact_names] - f.extractall(tmpdirname, members=members) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(f, tmpdirname, members=members) self.logger.info('Loading fields') self.fields = torch.load(