Can this be a part of lsp-mode?

[kiennq]

Hi @kassick,
I've come across your project and lsp-mode is actually missing the inlineCompletions support now. Would it be possible to contribute this to lsp-mode so that everything will be in a single package, better for user experience?

[kassick]

Hi!

If the maintainers think that it makes sense to upstream, sure!

(Though, it is mostly UI, other than the kludge to include the inlineCompletions command and its interfaces))

There is some glitch in the response handling that needs fixing -- the lsp-inline-completion function asks for inline completions and normalizes the response. At first, I had both gitlab-lsp and copilot-lsp active and it worked as expected. After I stopped using gitlab-lsp, sometimes the response cached in lsp--inline-completions was not of the expected type . At the time, I did not have enough time to debug it and switched to using upstream copilot.el .

Anyway, this glitch needs to be fixed when upstreaming, but otherwise I'm OK with upstreaming it.