No time display when not english

[Commifreak]

When I use english as locale, the Widget uses correct time format (Is use DateTimePicker, so this should be clear.

en-US

de-DE

Why is the time here missing? Is something unconfigured here?

Field-Config:

	[
		'attribute' => 'show_till',
		'type' => DetailView::INPUT_DATETIME,
		'widgetOptions' => [
			'pluginOptions' => [
				'autoclose' => true
			]
		]
	],

[Commifreak]

No idea? Is something wrong with some Yii2 configuration parameters? Id ont got it fixed, yet.

[kartik-v]

You have to set the language property of the widget to de which must reflect within widgetOptions in your code above.

Read the docs for DateTimePicker widget settings. The language is needed if you need locale specific implementation.

It will default to Yii::$app->language - and if you have already set that to de - then you need to debug the format masks for date time.

[Commifreak]

Hi,

I got it - the language is set properly to de, but in the .de locale file, the date format is wrong: https://github.com/kartik-v/yii2-widget-datetimepicker/blob/master/assets/js/locales/bootstrap-datetimepicker.de.js#L16

This would be the file for a datepicker - not for dateTIMEpicker.

Is this fixable through you or should I set this manually? I believe this is a wrong setting for this file.

[kartik-v]

No just set the pluginOptions['format'] property to what you need.

[kartik-v]

For example

'pluginOptions' => [
    'format' => 'dd.mm.yyyy hh:ii'
]

But you can submit a PR to change the DE locale file to include a default like above.

[Commifreak]

But this is hard coded then. This results in fixed format for every language then, right? It should auto-switch. In my eyes the file has wrong format. The file, linked above, should have defaults to:

format: 'dd.mm.yyyy HH:ii:ss' as it's aslo the default for en:

    getDefaultFormat: function (type, field) {
      if (type == 'standard') {
        if (field == 'input')
          return 'yyyy-mm-dd hh:ii';

I see, the language files have different defaults - some with time, some without. But this here is a dateTIMEpicker, so here we should set the time within defaults. If someone wants no time, we should use the https://github.com/kartik-v/yii2-widget-datepicker or am I wrong?

[kartik-v]

As I mentioned you can submit a pull request to change the default format for german language in the de locale file... these are defaults from the source plugin (maintained by different author).

[Commifreak]

Ok, thanks :)

[Commifreak]

Ah, now I understand the "why": The original author did not seperated datepicker and datetimepicker and thus your datetimepicker uses the default locale from the developer.

I create a Pull request ;)