Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header reders even if it empty and without close button #19

Closed
k-timoshenko opened this issue Sep 22, 2017 · 0 comments
Closed

Header reders even if it empty and without close button #19

k-timoshenko opened this issue Sep 22, 2017 · 0 comments

Comments

@k-timoshenko
Copy link

Steps to reproduce the issue

  1. Write code like this:
<?= PopoverX::widget([
    'header'       => NULL,
    'closeButton'  => NULL,
    'content'      => 'lorem ipsum',
    'toggleButton' => [
        'label' => $user->getFollowersCount(),
        'class' => 'btn btn-primary',
    ],
]); ?>

Expected behavior and actual behavior

When I follow those steps, I see...
Popover rendered with empty header line.

I was expecting...
Header does not rendered.

Libraries

  • yii2-popover-x version: v1.3.4

Solution

PopoverX::renderCloseButton method returns empty line if close button no rendred, but PopoverX::renderHeader method checks if close button is null.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants