Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #5188: Fix the issue of residual work in the MultiClusterService #5213

Conversation

XiShanYongYe-Chang
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang commented Jul 17, 2024

Cherry pick of #5188 on release-1.8.
#5188: Fix the issue of residual work in the MultiClusterService
For details on the cherry pick process, see the cherry pick requests page.

karmada-controller-manager: fix the issue of residual work in the MultiClusterService feature.

@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 17, 2024
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the automated-cherry-pick-of-#5188-upstream-release-1.8 branch from d520e73 to 28b86d6 Compare July 17, 2024 07:47
@RainbowMango
Copy link
Member

The test is failing, seems releated:

STEP: Creating MultiClusterService(karmadatest-k7rxx/mcs-84vtk) @ 07/17/24 08:09:54.947
  STEP: Creating PropagationPolicy(karmadatest-k7rxx/mcs-8m7w7) @ 07/17/24 08:09:54.959
  STEP: Creating Pod(karmadatest-k7rxx/mcs-8m7w7) @ 07/17/24 08:09:54.969
  STEP: Creating Deployment(karmadatest-k7rxx/mcs-8m7w7) @ 07/17/24 08:09:54.976
  STEP: Creating Service(karmadatest-k7rxx/mcs-84vtk) @ 07/17/24 08:09:54.981
  STEP: Waiting for pod(karmadatest-k7rxx/mcs-8m7w7) synced on member clusters @ 07/17/24 08:09:54.998
  STEP: Waiting for deployment(karmadatest-k7rxx/mcs-8m7w7) synced on member clusters @ 07/17/24 08:10:00.011
  [FAILED] in [It] - /home/runner/work/karmada/karmada/test/e2e/mcs_test.go:713 @ 07/17/24 08:15:00.022
  STEP: Removing MultiClusterService(karmadatest-k7rxx/mcs-84vtk) @ 07/17/24 08:15:00.022
  STEP: Removing PropagationPolicy(karmadatest-k7rxx/mcs-8m7w7) @ 07/17/24 08:15:00.043
  STEP: Removing Pod(karmadatest-k7rxx/mcs-8m7w7) @ 07/17/24 08:15:00.049
  STEP: Removing Deployment(karmadatest-k7rxx/mcs-8m7w7) @ 07/17/24 08:15:05.067
  STEP: Removing Service(karmadatest-k7rxx/mcs-84vtk) @ 07/17/24 08:15:05.07
  << Timeline

  [FAILED] Timed out after 300.001s.
  Expected
      <bool>: false
  to be true
  In [It] at: /home/runner/work/karmada/karmada/test/e2e/mcs_test.go:713 @ 07/17/24 08:15:00.022

  Full Stack Trace
    github.com/karmada-io/karmada/test/e2e.glob..func20.6.3()
    	/home/runner/work/karmada/karmada/test/e2e/mcs_test.go:713 +0x403

@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the automated-cherry-pick-of-#5188-upstream-release-1.8 branch from 28b86d6 to 0d21a5e Compare July 17, 2024 08:22
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2024
@karmada-bot karmada-bot merged commit 2347bf9 into karmada-io:release-1.8 Jul 17, 2024
12 checks passed
@XiShanYongYe-Chang XiShanYongYe-Chang deleted the automated-cherry-pick-of-#5188-upstream-release-1.8 branch August 17, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants