-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support install metrics adapter with chart #4303
Conversation
Signed-off-by: jwcesign <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4303 +/- ##
==========================================
- Coverage 52.80% 52.79% -0.01%
==========================================
Files 240 240
Lines 23624 23624
==========================================
- Hits 12474 12473 -1
- Misses 10471 10472 +1
Partials 679 679
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/cc @RainbowMango |
/assign @chaosi-zju |
/lgtm it is okey |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
feat: support install metrics adapter with chart
Which issue(s) this PR fixes:
Fixes #3626
Special notes for your reviewer:
Testing result:
1.Install
2.join cluster
3.query metrics
Does this PR introduce a user-facing change?: