Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support install metrics adapter with chart #4303

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

jwcesign
Copy link
Member

@jwcesign jwcesign commented Nov 22, 2023

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: support install metrics adapter with chart

Which issue(s) this PR fixes:
Fixes #3626

Special notes for your reviewer:
Testing result:
1.Install
image

2.join cluster
image

3.query metrics

image

Does this PR introduce a user-facing change?:

`Helm Chart`: Now able to install the component `karmada-metrics-adapter` with the chart.

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 22, 2023
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 22, 2023
@jwcesign
Copy link
Member Author

/cc @XiShanYongYe-Chang @chaosi-zju

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bf1098b) 52.80% compared to head (d86d922) 52.79%.
Report is 6 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4303      +/-   ##
==========================================
- Coverage   52.80%   52.79%   -0.01%     
==========================================
  Files         240      240              
  Lines       23624    23624              
==========================================
- Hits        12474    12473       -1     
- Misses      10471    10472       +1     
  Partials      679      679              
Flag Coverage Δ
unittests 52.79% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwcesign
Copy link
Member Author

/cc @RainbowMango

@RainbowMango
Copy link
Member

/assign @chaosi-zju
cc @zhzhuang-zju for checking the TLS thing.

@chaosi-zju
Copy link
Member

/lgtm it is okey

@zhzhuang-zju
Copy link
Contributor

zhzhuang-zju commented Nov 24, 2023

/assign @chaosi-zju cc @zhzhuang-zju for checking the TLS thing.

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2023
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2023
@karmada-bot karmada-bot merged commit cf1dbf0 into karmada-io:master Nov 24, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: deploy karmada-metreics-adapter with helm/karmadactl/karmada-operator
6 participants