Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Golang version from v1.20.6 to v1.20.10 #4169

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Updated Golang version from v1.20.6 to v1.20.10 #4169

merged 1 commit into from
Oct 24, 2023

Conversation

vikash485
Copy link
Contributor

@vikash485 vikash485 commented Oct 24, 2023 •
edited by RainbowMango
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR updates the default Go version for CI and release bots to v1.20.10

Which issue(s) this PR fixes:
Fixes #4166

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Karmada(v1.8) is now built with Go1.20.10.

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 24, 2023
@karmada-bot
Copy link
Collaborator

Welcome @vikash485! It looks like this is your first PR to karmada-io/karmada 🎉

@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 24, 2023
@RainbowMango
Copy link
Member

Hi @vikash485 Thanks for picking this.
Please squash commits and sign your commit as per https://github.com/karmada-io/karmada/pull/4169/checks?check_run_id=17994919541.

@vikash485
Update ci-schedule.yml
6ec5529 
Signed-off-by: Vikash Sangai <[email protected]>

Update ci.yml

Signed-off-by: Vikash Sangai <[email protected]>

Update cli.yaml

Signed-off-by: Vikash Sangai <[email protected]>

Update ci.yml

Signed-off-by: Vikash Sangai <[email protected]>

Update dockerhub-latest-image.yml

Signed-off-by: Vikash Sangai <[email protected]>

Update dockerhub-released-image.yml

Signed-off-by: Vikash Sangai <[email protected]>

Update release.yml

Signed-off-by: Vikash Sangai <[email protected]>

Update swr-latest-image.yml

Signed-off-by: Vikash Sangai <[email protected]>

Update swr-released-image.yml

Signed-off-by: Vikash Sangai <[email protected]>

Updated Golang version from v1.20.6 to v1.20.10
Signed-off-by: Vikash Sangai <[email protected]>
@vikash485
Copy link
Contributor Author

Hi @vikash485 Thanks for picking this. Please squash commits and sign your commit as per https://github.com/karmada-io/karmada/pull/4169/checks?check_run_id=17994919541.

Hey, thanks for the help regarding the commits. I tried doing the same, can you verify if this is okay now?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0fe6f14) 52.98% compared to head (6ec5529) 52.98%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4169   +/-   ##
=======================================
  Coverage   52.98%   52.98%           
=======================================
  Files         239      239           
  Lines       23494    23494           
=======================================
  Hits        12449    12449           
  Misses      10369    10369           
  Partials      676      676
Flag Coverage Δ
unittests 52.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

RainbowMango
RainbowMango approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2023
@karmada-bot karmada-bot merged commit 60af4e8 into karmada-io:master Oct 24, 2023
12 checks passed
@RainbowMango RainbowMango mentioned this pull request Nov 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RainbowMango RainbowMango RainbowMango approved these changes

@chaunceyjiang chaunceyjiang Awaiting requested review from chaunceyjiang

Assignees

@RainbowMango RainbowMango

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Golang version from v1.20.6 to v1.20.10
4 participants
@vikash485 @karmada-bot @RainbowMango @codecov-commenter