-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Sync workload's status.observedGeneration if it's updated #4138
Conversation
Signed-off-by: jwcesign <[email protected]>
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4138 +/- ##
==========================================
- Coverage 53.46% 53.39% -0.08%
==========================================
Files 234 234
Lines 23279 23307 +28
==========================================
- Hits 12447 12445 -2
- Misses 10150 10180 +30
Partials 682 682
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Referring to #4137
When the deployment is updated in spe, we need to trigger the status update. To resolve the inconsistent generation.
Which issue(s) this PR fixes:
Fixes #4137
Special notes for your reviewer:
none
Does this PR introduce a user-facing change?: