Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sync workload's status.observedGeneration if it's updated #4138

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

jwcesign
Copy link
Member

@jwcesign jwcesign commented Oct 17, 2023

What type of PR is this?
/kind bug

What this PR does / why we need it:
Referring to #4137
When the deployment is updated in spe, we need to trigger the status update. To resolve the inconsistent generation.

Which issue(s) this PR fixes:
Fixes #4137

Special notes for your reviewer:
none

Does this PR introduce a user-facing change?:

`karmada-controller-manager`: Fixed inconsistent generation issue between `metadata.generation` and `status.observedGeneration`.

@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 17, 2023
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 17, 2023
@jwcesign
Copy link
Member Author

@codecov-commenter
Copy link

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (f56af66) 53.46% compared to head (e50f414) 53.39%.
Report is 4 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4138      +/-   ##
==========================================
- Coverage   53.46%   53.39%   -0.08%     
==========================================
  Files         234      234              
  Lines       23279    23307      +28     
==========================================
- Hits        12447    12445       -2     
- Misses      10150    10180      +30     
  Partials      682      682              
Flag Coverage Δ
unittests 53.39% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/controllers/status/crb_status_controller.go 47.54% <0.00%> (-0.80%) ⬇️
pkg/controllers/status/rb_status_controller.go 46.03% <0.00%> (-0.75%) ⬇️
pkg/controllers/status/common.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2023
@karmada-bot karmada-bot merged commit d6cc5b9 into karmada-io:master Oct 24, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: workflow stays pending for a long time
4 participants