-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support config karmada components resources #4059
support config karmada components resources #4059
Conversation
0aec7ee
to
68b53da
Compare
68b53da
to
a20e8de
Compare
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4059 +/- ##
==========================================
+ Coverage 53.82% 53.84% +0.02%
==========================================
Files 231 231
Lines 23013 23013
==========================================
+ Hits 12386 12391 +5
+ Misses 9954 9950 -4
+ Partials 673 672 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
It looks good. @jwcesign @RainbowMango PTAL /lgtm |
Just noticed that you are using your Chinese name in your commit: Author: 张潇 <[email protected]>
Date: Wed Sep 13 18:09:23 2023 +0800
support config karmada components resources
Signed-off-by: 张潇 <[email protected]> I'm not sure if GitHub or CNCF tools could count your contribution. This is concerning. |
a20e8de
to
f916596
Compare
c7eea2c
to
845b31a
Compare
I recently changed my computer and I checked and it shouldn't be affected. I revised it again, thx |
845b31a
to
3d7619d
Compare
Signed-off-by: wawa0210 <[email protected]>
3d7619d
to
ab1900f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
The karmada operator does not support users to explicitly set the resource scale of each component. But resource planning will be different in different scenarios, so we can provide explicit configuration
Which issue(s) this PR fixes:
from #3732 (comment)
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Test Results
karmada instance yaml with resources config
actual effect