uninstall metrics adapter when karmada cluster remove #4056
Conversation
karmada-bot
added
the
size/XS
wawa0210
force-pushed
the
remove-mertics-adapter-cluster-rm
branch
from
c15faa9
to
8be8210
Compare
Codecov ReportPatch and project coverage have no change.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4056 +/- ##
=======================================
Coverage 53.81% 53.81%
=======================================
Files 231 231
Lines 23013 23013
=======================================
Hits 12385 12385
Misses 9955 9955
Partials 673 673
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| newRemoveComponentWithServiceSubTask(constants.KarmadaAPIserverComponent, util.KarmadaAPIServerName), | ||
| newRemoveComponentWithServiceSubTask(constants.KarmadaAPIserverComponent, util.KarmadaAPIServerName), |
There was a problem hiding this comment.
Remove the same component twice?
wawa0210
force-pushed
the
remove-mertics-adapter-cluster-rm
branch
from
8be8210
to
b4e54cf
Compare
Signed-off-by: 张潇 <[email protected]>
wawa0210
force-pushed
the
remove-mertics-adapter-cluster-rm
branch
from
b4e54cf
to
d928c11
Compare
|
/lgtm |
|
/lgtm |
There was a problem hiding this comment.
/approve
I added a release-note to the PR description.
@calvin0327 Do you think this patch should be backported to release branches?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
|
@RainbowMango Yes, I think we should patch to v1.7 release branch, how do you think? |
|
+1 @wawa0210 Would you like to do this? Here is the guide about how to cherry-pick a PR: |
sure, let me do it |
…-upstream-release-1.7 Automated cherry pick of #4056: uninstall metrics adapter when karmada cluster remove
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #4030
When the karmada instance is removed, the metrics-adapter does not have a corresponding de-init, causing the pod to remain.
Special notes for your reviewer:
Does this PR introduce a user-facing change?: