Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix invalid helm chart #4034

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Conversation

chaosi-zju
Copy link
Member

@chaosi-zju chaosi-zju commented Sep 6, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

  • chart file karmada-search.yaml is invalid
  • lack of enough check method of chart file

Which issue(s) this PR fixes:
Fixes #4035

Special notes for your reviewer:

before:
image

now:
image

image

Does this PR introduce a user-facing change?:

`helm-chart`: Fixed the issue that can not install `karmada-search`.

Signed-off-by: chaosi-zju <[email protected]>
@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 6, 2023
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 6, 2023
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2023
@karmada-bot karmada-bot merged commit 6bae737 into karmada-io:master Sep 7, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the helm chart of karmada-search.yaml is invalid
3 participants