Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherrypick #4144: fix cannot access ResourceRegistry with its singularName #4152

Closed
3 tasks done
XiShanYongYe-Chang opened this issue Oct 20, 2023 · 5 comments
Closed
3 tasks done
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@XiShanYongYe-Chang
Copy link
Member

XiShanYongYe-Chang commented Oct 20, 2023

Which PR needs cherry-picks:

PR #4144

Which release branches need this patch:

How to cherry-pick PRs:

The hack/cherry_pick_pull.sh script can help you initiate a cherry-pick
automatically, please follow the instructions at this guideline.

The script will send the PR for you, please remember copy the release notes from
the original PR by to the new PR description part.

How to join or take the task:

Just reply on the issue with the message /assign in a separate line.

Then, the issue will be assigned to you.

Useful References:

Anything else we need to know:

@XiShanYongYe-Chang XiShanYongYe-Chang added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Oct 20, 2023
@Yan-Daojiang
Copy link
Contributor

/assign

@RainbowMango
Copy link
Member

@XiShanYongYe-Chang
release-1.5 and release-1.6 aren't affected by this bug. (I tested against v1.5.4, there is no problem.)

This bug was introduced by #3730 when we updated Kubernetes dependencies to v1.27. So, we only need to fix it at release-1.7 and master.

There is no side-effect checking them to release-1.5 and release-1.6 though.

@XiShanYongYe-Chang
Copy link
Member Author

@RainbowMango Ok, thanks

This bug was introduced by #3730

I'd like to know how this is confirmed.

@XiShanYongYe-Chang
Copy link
Member Author

/close

@karmada-bot
Copy link
Collaborator

@XiShanYongYe-Chang: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

No branches or pull requests

4 participants