Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce cherry-pick tools #1210

Closed
2 tasks done
RainbowMango opened this issue Jan 4, 2022 · 10 comments · Fixed by #1230
Closed
2 tasks done

Introduce cherry-pick tools #1210

RainbowMango opened this issue Jan 4, 2022 · 10 comments · Fixed by #1230
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@RainbowMango
Copy link
Member

RainbowMango commented Jan 4, 2022

What would you like to be added:

Why is this needed:

@RainbowMango RainbowMango added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 4, 2022
@RainbowMango RainbowMango added this to the v1.1 milestone Jan 4, 2022
@jameszhangyukun
Copy link
Contributor

jameszhangyukun commented Jan 4, 2022

/assign I want to try two tasks

@carlory
Copy link
Member

carlory commented Jan 5, 2022

@jameszhangyukun

Sorry, I did not notice this issue, I have already submitted a related PR #1216

/assign

@RainbowMango
Copy link
Member Author

@jameszhangyukun Have you started this task?

@jameszhangyukun
Copy link
Contributor

@jameszhangyukun Have you started this task?

I just read https://github.com/kubernetes/kubernetes/blob/master/hack/cherry_pick_pull.sh do not begin this task

@RainbowMango
Copy link
Member Author

So, how do you want to move this issue forward? You can help review #1216 or submit a new PR, it's up to you.

@carlory Thanks for your contribution, but since this issue has been claimed by @jameszhangyukun , I need confirmation before moving your PR. Hope you can understand.

@jameszhangyukun
Copy link
Contributor

jameszhangyukun commented Jan 6, 2022

So, how do you want to move this issue forward? You can help review #1216 or submit a new PR, it's up to you.

@carlory Thanks for your contribution, but since this issue has been claimed by @jameszhangyukun , I need confirmation before moving your PR. Hope you can understand.

If he finish this issue.I think you can receive his PR. This is ok

@carlory
Copy link
Member

carlory commented Jan 6, 2022

@RainbowMango @jameszhangyukun

sorry, it's my mistake. I will be more careful next time.

@jameszhangyukun
Copy link
Contributor

jameszhangyukun commented Jan 6, 2022

@RainbowMango @jameszhangyukun

sorry, it's my mistake. I will be more careful next time.

It doesn't matter.Don't blame yourself.

@RainbowMango
Copy link
Member Author

@carlory Don't get me wrong, It's not your fault.

We are following the first-come-first-serve rule, all contributor's efforts are fully respected.

@RainbowMango
Copy link
Member Author

Thanks @jameszhangyukun for your cooperation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants