fix(ci): stop the proxy before killing the child #3469
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix karma-runner#3464, hopefully. Since the test is flaky and only on Travis we can't be sure until we try for awhile.
|
✅ Build karma 2584 completed (commit d5e7da273a by @johnjbarton) |
|
✅ Build karma 186 completed (commit d5e7da273a by @johnjbarton) |
|
✅ Build karma 185 completed (commit d5e7da273a by @johnjbarton) |
kyliau
approved these changes
Apr 9, 2020
|
This did not work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #3464, hopefully. Since the test is flaky and only on Travis
we can't be sure until we try for a while.