-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove support for node 6 #3246
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please describe the breaking change (and our reasons):
http://karma-runner.github.io/3.0/dev/git-commit-msg.html
We also need to have a similar change to the integration-tests project, and land it before any async changes.
@johnjbarton Thank you, I've updated commit message. What you mean by "integration-tests project" ? |
The karma-runner integration tests (tests with plugins) are configured here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also a documentation line:
Maybe we can replace That is 6.x, 8.x and 10.x at this point.
with something that acknowledges the version dependency. You may need to install older versions of karma-runner if you must support older versions of nodejs. For example, to run on nodejs 6.x, install karma-runner 3.x.
Then in future we can just leave this doc file as is.
I created pull request on integration-tests project: Yeah, it would be nice to update this documentation line - do you have proposition for whole section ? Because currently it contains |
to eg: Karma is tested on (at least) the |
Okay, I updated this info in docs. |
Set node 8 as minimal supported version. Closes #3151 BREAKING CHANGE: Drop Support for Node 6, to make it possible to use async/await in karma codebase.
This pull request remove support for node v6.
Let me know if I missed something here ...