-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crashes on save #963
Comments
I also have this happening on Linux (Archlinux) using Karma 0.12.1:
EDIT:
So it should not even include those temp files even if they're created on save and then deleted. |
a workaround for this is running karma with auto-watch false and doing karma run. Kinda defeats the purpose but if you don't want it to crash on every save. |
This sounds like an issue with the respective editors in use. What are you using @bibodha? |
While it might be editor that is producing the bug, it's not the editors issue that karma fails. Karma in first place shouldn't match My wild guess it's a race condition - karma gets notified that there is a change, it follows up with stat on the file, but the file is already deleted. |
Looks like the problem is here: https://github.com/karma-runner/karma/blob/master/lib/file_list.js#L305 The file is gone by the time stat is being called. I guess having SSD + Linux with it's filesystem caching magic improves the chance to get this error. |
@dignifiedquire As mentioned previously: VMWare Fusion 6.0.2 on Mac OSX v10.9.2 Plugins: jasmine, require, coverage, phantomjs-launcher, chrome-launcher |
@MaikuMori can you put Can you guys also try setting Yep, this is a bug, Line 305 in cc6386f
Actually, when fixing this. We should not do the stat, if the stat is already provided by chokidar (when |
Possibly this is the same issue as #959? File gets renamed before Chokidar stats it; then the stat fails. PR #1020 should fix the crash; though whether it leaves any issues with changes not being detected, I'm not yet sure (haven't seen it; but if there are unhandled races between the editor and Chokidar, it might be a possibility) |
Is this still an issue? |
As we haven't heard any more reports of this problem in 4 years, I think it is pretty safe to assume that it was resolved. Happy to re-open if anybody still experiences the problem and can provide a reproduction. |
Karma v0.12.0
Browswer: Chrome 33.0.1750 (Windows 7)
Windows 7 running on VMWare on Mac OSX 10.9
Error Message:
This also happens when running PhantomJS instead of Chrome and happens very frequently.
The text was updated successfully, but these errors were encountered: